[PATCH] D58457: [llvm-readobj]Add testing for ELF symbol and section table printing for a wider range of values

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 21 04:31:16 PST 2019


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/tools/llvm-readobj/elf-section-types.test:1
+# Show that all section types are properly printed for both LLVM and GNU styles.
+
----------------
nit: all **regular ** maybe? (since machine-specific are tested in elf-machine-specific-section-types.test)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58457/new/

https://reviews.llvm.org/D58457





More information about the llvm-commits mailing list