[PATCH] D58389: [NFC][LSR] Cleanup Cost API

Gil Rapaport via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 21 01:09:43 PST 2019


gilr added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopStrengthReduce.cpp:1018
   TargetTransformInfo::LSRCost C;
+  const Formula *F = nullptr;
 
----------------
TTI et al. persist throughout Cost's life so it makes sense to initialize the object with them and keep them as members. IINM F is limited to rateFormula() -  seems more natural to keep F as its argument (and risky to keep it beyond rateFormula()'s scope).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58389/new/

https://reviews.llvm.org/D58389





More information about the llvm-commits mailing list