[PATCH] D58313: [hwasan,asan] Intercept vfork.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 18:01:11 PST 2019


pcc added inline comments.


================
Comment at: compiler-rt/test/asan/TestCases/Linux/vfork.cc:4
+
+// REQUIRES: aarch64-android-target-arch
+
----------------
eugenis wrote:
> pcc wrote:
> > Doesn't this need to be spelled `REQUIRES: aarch64-target-arch, android`? (Also, does it really require Android?)
> I've dumped available features, and that's the only relevant one I found.
> Perhaps this could be fixed, but in a separate commit.
That's fine. I noticed that `compiler-rt/test/shadowcallstack/overflow-aarch64.c` was already using `aarch64-target-arch`, maybe that's never being run? If so that would probably need to be fixed as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58313/new/

https://reviews.llvm.org/D58313





More information about the llvm-commits mailing list