[PATCH] D57927: [llvm-ar] Implement the P modifier.

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added a comment.

In D57927#1405047 <https://reviews.llvm.org/D57927#1405047>, @thakis wrote:

> > Hmm, that's right. That's probably a good reason why we can't make P the default behavior.
>
> Doesn't that make the output dependent on the build directory path? In Chromium, we're very careful to try and make the build independent of the build directory name for deterministic builds. I think changing the default here is bad for this reason. If you have your mind set on this however, is there an opt out flag? (We don't use llvm-ar in chromium at the moment so this doesn't affect us, but it's maybe a concern you didn't think about, so I figured I'd mention it.)


The member paths in thin archives are relative to the archive itself. So suppose you have two build trees and you want to cmp the difference of every file in each tree to make sure they're bit-for-bit identical. Won't the archive members be the same relative path to the archive within each build tree? If so, the thin archive contents will be bit-for-bit identical.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57927/new/

https://reviews.llvm.org/D57927