[PATCH] D57927: [llvm-ar] Implement the P modifier.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 17:07:27 PST 2019


thakis added a comment.

> Hmm, that's right. That's probably a good reason why we can't make P the default behavior.

Doesn't that make the output dependent on the build directory path? In Chromium, we're very careful to try and make the build independent of the build directory name for deterministic builds. I think changing the default here is bad for this reason. If you have your mind set on this however, is there an opt out flag? (We don't use llvm-ar in chromium at the moment so this doesn't affect us, but it's maybe a concern you didn't think about, so I figured I'd mention it.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57927/new/

https://reviews.llvm.org/D57927





More information about the llvm-commits mailing list