[PATCH] D58231: [LICM] Support of widenable condition guards in LICM

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 13:54:49 PST 2019


fedor.sergeev added a comment.

In D58231#1404251 <https://reviews.llvm.org/D58231#1404251>, @reames wrote:

> Does the existing code successfully hoist the widenable_condition call itself out of the loop?  If not, splitting out specifically that part of the transform would be well called for and necessary for unswitch to make progress.  If it does, then the patch as written includes redundant handling which should be removed.


Current trunk can not hoist this widenable call.
Hence it makes sense to modify this fix so it hoists the call itself (and perhaps the rest of condition) but keeps the branch unmodified, for unswitch later to finish the task.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58231/new/

https://reviews.llvm.org/D58231





More information about the llvm-commits mailing list