[PATCH] D58432: SanitizerCommon: 64-bit SPARC/Linux port

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 11:14:23 PST 2019


vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_allocator_primary32.h:188
     uptr mem = reinterpret_cast<uptr>(p);
+    if (kSignExtendedAddresses)
+      mem &= (kSpaceSize - 1);
----------------
why do we need kSignExtendedAddresses?
Could we just do
```
if (SANITIZER_SIGN_EXTENDED_ADDRESSES)
  mem &= (kSpaceSize - 1);
```


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58432/new/

https://reviews.llvm.org/D58432





More information about the llvm-commits mailing list