[PATCH] D49366: [LLD][COFF] Add support for /FUNCTIONPADMIN command-line option

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 10:01:46 PST 2019


ruiu added inline comments.


================
Comment at: COFF/DriverUtils.cpp:260-261
+      error("/functionpadmin: invalid argument: " + Arg);
+      return;
+    }
+  } else {
----------------
Return early.


================
Comment at: COFF/InputFiles.h:163
 
+  llvm::Optional<bool> HotPatchable;
+
----------------
Why Optional?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49366/new/

https://reviews.llvm.org/D49366





More information about the llvm-commits mailing list