[PATCH] D58455: [llvm-readobj]Test basic command-line handling

[James Henderson via Phabricator via llvm-commits]

jhenderson created this revision.
jhenderson added reviewers: grimar, rupprecht, MaskRay.
Herald added a project: LLVM.

There was no real testing for llvm-readobj/llvm-readelf's behaviour under various bad inputs and command-line switches. This patch adds some testing of this, along with basic testing of --version and --help.


Repository:
  rL LLVM

https://reviews.llvm.org/D58455

Files:
  test/tools/llvm-readobj/basic.test


Index: test/tools/llvm-readobj/basic.test
===================================================================
--- test/tools/llvm-readobj/basic.test
+++ test/tools/llvm-readobj/basic.test
@@ -1,2 +1,32 @@
 RUN: not llvm-readobj %t.blah 2>&1 | FileCheck --check-prefix=ENOENT %s
 ENOENT: {{.*}}.blah: {{[Nn]}}o such file or directory
+
+RUN: touch %t.empty
+RUN: not llvm-readobj %t.empty 2>&1 | FileCheck --check-prefix=EMPTY %s
+EMPTY: {{.*}}.empty: The file was not recognized as a valid object file
+
+RUN: rm -f %t.a
+RUN: llvm-ar rc %t.a %t.empty
+RUN: llvm-readobj --all %t.a 2>&1 | FileCheck --check-prefix=NO-OUTPUT --allow-empty %s
+NO-OUTPUT-NOT: {{.}}
+
+# Test case where no switches are specified.
+RUN: llvm-readobj %p/Inputs/trivial.obj.elf-x86-64 | FileCheck --check-prefix=HEADER %s
+RUN: llvm-readelf %p/Inputs/trivial.obj.elf-x86-64 | FileCheck --check-prefix=NO-OUTPUT --allow-empty %s
+HEADER: File: {{.*}}trivial.obj.elf-x86-64
+HEADER: Format: ELF64-x86-64
+HEADER: Arch: x86_64
+HEADER: AddressSize: 64bit
+
+RUN: not llvm-readobj --unknown-switch 2>&1 | FileCheck --check-prefix=UNKNOWN %s
+UNKNOWN: Unknown command line argument '--unknown-switch'
+
+RUN: llvm-readobj --version | FileCheck %s --check-prefix=VERSION
+RUN: llvm-readelf --version | FileCheck %s --check-prefix=VERSION
+VERSION: LLVM version
+
+RUN: llvm-readobj --help | FileCheck %s --check-prefixes=HELP,USAGE-OBJ
+RUN: llvm-readelf --help | FileCheck %s --check-prefixes=HELP,USAGE-ELF
+HELP: OVERVIEW: LLVM Object Reader
+USAGE-OBJ: llvm-readobj{{.*}} [options] <input object files>
+USAGE-ELF: llvm-readelf{{.*}} [options] <input object files>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58455.187592.patch
Type: text/x-patch
Size: 1641 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190220/5e27b6b4/attachment.bin>