[PATCH] D58170: [DTU] Refine the interface and logic of applyUpdates

[Brian Rzycki via Phabricator via llvm-commits]

brzycki added a comment.

@NutshellySima I like the idea of the new naming scheme that makes usage more explicit.

I noticed there are no changes to `JumpThreading.cpp`, do they need to be altered in a separate patch or are you fine with all of `applyUpdates` implicitly becoming `applyUpdatesHinted` in `Lazy` mode?

I also find the name `applyUpdatesHinted` a bit confusing and had to read your comments above to understand Hinted meant "we check the CFG for validity". Maybe use `applyUpdatesChecked` or `applyUpdatesValidated` as an alternative name that makes it a bit more clear that extra work must be done for this set of updates.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58170/new/

https://reviews.llvm.org/D58170