[PATCH] D58351: ARM: Add ImmArg to intrinsics

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: include/llvm/IR/IntrinsicsARM.td:317
 def int_arm_mrrc2 : Intrinsic<[llvm_i32_ty, llvm_i32_ty], [llvm_i32_ty,
                                llvm_i32_ty, llvm_i32_ty], []>;
 
----------------
rovka wrote:
> I think these should also have immediate arguments, at least according to https://reviews.llvm.org/source/clang/browse/cfe/trunk/test/Sema/builtins-arm.c
> 
> Is there any reason why we should skip them? (I can see that they're just Intrinsic as opposed to GCCBuiltin, and the commit message says they wouldn't be included, but I don't really understand why you chose only GCCBuiltins).
My assert method can only find the cases that use GCCBuiltin, All intrinsics with this constraint need it, but those require manually auditing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58351/new/

https://reviews.llvm.org/D58351