[PATCH] D57680: [llvm-objdump] Implement `-Mreg-names-raw`/`-std` options.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 03:56:55 PST 2019


jhenderson added inline comments.


================
Comment at: test/tools/llvm-objdump/ARM/reg-names.s:7-8
+@ RUN:   | FileCheck -check-prefix=RAW %s
+@ RUN: llvm-objdump -d --disassembler-options reg-names-raw %t \
+@ RUN:   | FileCheck -check-prefix=RAW %s
+@ RUN: llvm-objdump -d -Mreg-names-raw,reg-names-std %t \
----------------
This is a duplicate of the check immediately above?


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1487
+    if (!IP->applyTargetSpecificCLOption(Opt))
+      error("Unrecognized disassembler option: " + Opt);
+
----------------
Test case for this error message?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57680/new/

https://reviews.llvm.org/D57680





More information about the llvm-commits mailing list