[PATCH] D58412: [X86] Remove FeatureSlowIncDec from Sandy Bridge and later Intel Core CPUs

Tue Feb 19 17:53:16 PST 2019

spatel added a reviewer: chandlerc.
spatel added a comment.

In D58412#1403230 <https://reviews.llvm.org/D58412#1403230>, @craig.topper wrote:

> In D58412#1403190 <https://reviews.llvm.org/D58412#1403190>, @spatel wrote:
>
> > Should we change the generic model too then since most CPUs prefer inc/dec? 
> >  I'm guessing that's a lot more test diffs, so no problem to make it another patch, but just want to know if that's the way to think about the generic model.
>
>
> Related question to that. Should "pentium4" which is clang's Linux default CPU for 32-bit builds have more tuning flags on it?

I've never looked at how the 32-bit setting works...or at least I can't remember it now. :)
But that sounds weird. Shouldn't we have a generic 32-bit model similar to the generic 64-bit model?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58412/new/

https://reviews.llvm.org/D58412