[PATCH] D58399: [Inliner] Don't initialize ComputeFullInlineCost to be always true because of ORE

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 19 12:14:31 PST 2019


chandlerc added inline comments.


================
Comment at: lib/Analysis/InlineCost.cpp:282-285
+        // TODO: It is better to initialize ComputeFullInlineCost to true when
+        // Rpass=inline* is used to enable more precise report. However right
+        // now the check is inside of diagnose emission and we don't have a
+        // clean way to do the check here. It is something to be improved.
----------------
Can't we query ORE as well as this bool in inline cost?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58399/new/

https://reviews.llvm.org/D58399





More information about the llvm-commits mailing list