[PATCH] D58400: [AMDGPU] Implement AMDGPUMCInstrAnalysis

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCTargetDesc.cpp:122
+    int64_t Imm = Inst.getOperand(0).getImm();
+    APInt SignedOffset(18, Imm * 4, true);
+    Target = (SignedOffset.sext(64) + Addr + Size).getZExtValue();
----------------
Needs a comment for why this is 18


================
Comment at: test/MC/AMDGPU/branch-comment.s:9
+// BIN-NOT: loop_start:
+// BIN: s_branch 65535 // 000000000004: BF82FFFF <keep_symbol+0x4>
+
----------------
This should be printed as signed?


================
Comment at: test/MC/AMDGPU/branch-comment.s:15
+loop_end:
+  s_nop 0
----------------
Can you include some cases where it can't figure out an associated symbol?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58400/new/

https://reviews.llvm.org/D58400