[PATCH] D58380: [LLD] [COFF] Add -exclude-all-symbols for MinGW

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 19 10:49:57 PST 2019


ruiu added inline comments.


================
Comment at: COFF/Driver.cpp:1613
+  // than MinGW in the case that nothing is explicitly exported.
+  if (Config->DLL && ((Config->MinGW && Config->Exports.empty() &&
+                       !Args.hasArg(OPT_exclude_all_symbols)) ||
----------------
Shouldn't this be `Config->MinGW && Config->DLL && ...`? IIUC this is a mingw extension, and we don't want to run the code below if not mingw.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58380/new/

https://reviews.llvm.org/D58380





More information about the llvm-commits mailing list