[PATCH] D58119: [obj2yaml][yaml2obj] - Add support of parsing/dumping of the .gnu.version_r section.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: include/llvm/ObjectYAML/ELFYAML.h:186
+  std::vector<VerneedEntry> VerneedV;
+  llvm::yaml::Hex64 Info;
+
----------------
grimar wrote:
> jhenderson wrote:
> > `Info`? This section doesn't have anything to do with sh_info according to the specification (it uses sh_link to point at its string table).
> Its mentioned in a general spec about sh_info/sh_link fields for sections,
> see "Table 7-15 ELF sh_link and sh_info Interpretation":
> https://docs.oracle.com/cd/E19683-01/816-1386/chapter6-94076/index.html
> sh_info contains "The number of version dependencies within the section. ".
> 
> Both GNU and LLD linkers set this field.
> 
Ah, okay. It's not listed in the description of the specific section, unlike the sh_link field, which would have made much more sense...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58119/new/

https://reviews.llvm.org/D58119