[PATCH] D58363: [X86] Bugfix for nullptr check by klocwork

LuoYuanke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 18 21:05:57 PST 2019


LuoYuanke added inline comments.


================
Comment at: lib/Target/X86/X86InstructionSelector.cpp:1604
+  const RegisterBank *RegRB = RBI.getRegBank(DstReg, MRI, TRI);
+  if (!RegRB && RegRB->getID() != X86::GPRRegBankID)
     return false;
----------------
Use || instead of &&?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58363/new/

https://reviews.llvm.org/D58363





More information about the llvm-commits mailing list