[PATCH] D58338: [WebAssembly] Refactor atomic operation definitions (NFC)

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 18 17:44:33 PST 2019


tlively added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrAtomics.td:22
+
+multiclass ATOMIC_NRI<dag oops, dag iops, list<dag> pattern, string asmstr = "",
+                      bits<32> atomic_op = -1> {
----------------
aheejin wrote:
> tlively wrote:
> > It looks like this multiclass isn't used anywhere. Can it be omitted for simplicity?
> It's now used in D50277, the ever-pending CL. Do you think moving it there is better?
Oh I see. No, this seems fine the way it is 👍


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58338/new/

https://reviews.llvm.org/D58338





More information about the llvm-commits mailing list