[PATCH] D58295: AMDGPU: Fix memory dependence analysis by considering the offset.

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 18 14:45:01 PST 2019


cfang marked an inline comment as done.
cfang added inline comments.


================
Comment at: lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:264-265
   // RAR - safe to reorder
-  return !(A->mayStore() || B->mayStore()) ||
-         TII->areMemAccessesTriviallyDisjoint(*A, *B, AA);
 }
----------------
arsenm wrote:
> This merged part of the other patch
What do you mean here?  I think this is the staring point of the current patch. We are going to replace
TII->areMemAccessesTriviallyDisjoint with MI.mayAlias to fix the bug.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58295/new/

https://reviews.llvm.org/D58295





More information about the llvm-commits mailing list