[PATCH] D58078: GlobalISel: Implement widenScalar for g_extract scalar results

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 18 14:11:30 PST 2019


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/MachineIRBuilder.cpp:474
+  auto Extract = buildInstr(TargetOpcode::G_EXTRACT);
+  Dst.addDefToMIB(*getMRI(), Extract);
+  Src.addSrcToMIB(Extract);
----------------
aemerson wrote:
> Out of curiosity, why does this need changing?
A random assortment of functions in MachineIRBuilder don't use SrcOp/DstOp, so this makes it consistent with the other operations. I can commit this separately


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58078/new/

https://reviews.llvm.org/D58078





More information about the llvm-commits mailing list