[PATCH] D58356: Hexagon: Add ImmArg to intrinsics

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 18 09:56:29 PST 2019


arsenm added a comment.

In D58356#1401366 <https://reviews.llvm.org/D58356#1401366>, @kparzysz wrote:

> I'm not expecting this patch to be complete.  Most of the intrinsic definitions are actually auto-generated, so we'll need to update the generating scripts to include these new annotations.  What concerns me is that you claim that some things are missing, which could indicate that there are some issues with the generators.  I'm trying to understand exactly what the missing pieces are, the contents of this patch are actually of secondary importance.


I'm not claiming I know it's incomplete, it's just there are reasons the method for finding them can't catch 100% of cases. In hexagon's case in particular GCCBuiltin seems to be consistently used, so the coverage is probably better


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58356/new/

https://reviews.llvm.org/D58356





More information about the llvm-commits mailing list