[PATCH] D58352: Mips: Add ImmArg to intrinsics

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 18 08:01:32 PST 2019


arsenm created this revision.
arsenm added a reviewer: atanasyan.
Herald added subscribers: arichardson, wdng, sdardis.

I found these by asserting in clang for any GCCBuiltin that doesn't
require mangling and requires a constant for the builtin. This means
that intrinsics are missing which don't use GCCBuiltin, don't have
builtins defined in clang, or were missing the constant annotation in
 the builtin definition.

      

I'm not sure what's going on with the immediates.ll test. It seems to
be intended to test invalid cases like this, but then tries to handle
some of them anyway. I've moved the cases that were inconsistent with
the GCCBuiltin definition so they don't test the codegen anymore.


https://reviews.llvm.org/D58352

Files:
  include/llvm/IR/IntrinsicsMips.td
  test/CodeGen/Mips/msa/immediates.ll
  test/Verifier/Mips/intrinsic-immarg.ll
  test/Verifier/Mips/lit.local.cfg

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58352.187247.patch
Type: text/x-patch
Size: 46411 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190218/398f9f5c/attachment.bin>


More information about the llvm-commits mailing list