[PATCH] D58168: [yaml2obj] - Do not ignore explicit addresses for .dynsym and .dynstr

[George Rimar via Phabricator via llvm-commits]

grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: tools/yaml2obj/yaml2elf.cpp:324-325
 
+  // If .dynsym section is explicitly described in the YAML
+  // then we want to use its section address.
+  if (!IsStatic) {
----------------
grimar wrote:
> jhenderson wrote:
> > Nit: Let clang-format reflow your comments across multiple lines, rather than doing it by hand.
> Clang format would produce the following:
> 
> ```
>   // If .dynsym section is explicitly described in the YAML then we want to use
>   // its section address.
> ```
> 
> The first line is long, while the second is too short. It does not look nice. So you still want me to do that?
> ( I am often doing that by hand in such cases, btw).
"So you" -> "Do you"



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58168/new/

https://reviews.llvm.org/D58168