[PATCH] D58174: [yaml2obj] - Do not skip zeroes blocks if there are relocations against them.

Mon Feb 18 06:10:21 PST 2019

jhenderson added inline comments.

================
Comment at: test/tools/llvm-objdump/disasm-zeroes-relocations.test:2
+# RUN: yaml2obj %s > %t
+# RUN: llvm-objdump -D -reloc %t
+
----------------
Could you also add a case to this test showing that disassembly does skip the zeroes in this case, if the -reloc switch is not used, please?

================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1287-1288
+          uint64_t MaxOffset = End - Index;
+          // For -reloc: if we have relocations around, we want to keep zeroes
+          // blocks, because want to show the relocations in the dump.
+          if (RelCur != RelEnd)
----------------
I'd rephrase this slightly as "For -reloc: print zero blocks patched by relocations, so that relocations can be shown in the dump."

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58174/new/

https://reviews.llvm.org/D58174