[PATCH] D57904: [llvm-objdump] Allow short options to be grouped

[Matthew Voss via Phabricator via llvm-commits]

ormris marked 2 inline comments as done.
ormris added a comment.

Sounds good. Thanks again for the review!



================
Comment at: llvm/test/tools/llvm-objdump/AArch64/macho-fat-arm-disasm.test:2
 RUN: llvm-objdump -d -m -no-show-raw-insn -arch all %p/Inputs/fat.macho-armv7s-arm64 | FileCheck %s
+RUN: llvm-objdump -dm -no-show-raw-insn -arch all %p/Inputs/fat.macho-armv7s-arm64 | FileCheck %s
 REQUIRES: arm-registered-target
----------------
rupprecht wrote:
> These should use cmp to verify the files are identical, instead of just checking they match the same patterns
OK. Will fix.


================
Comment at: llvm/test/tools/llvm-objdump/option-grouping.test:1
+// RUN: llvm-objdump -afxz %p/Inputs/private-headers-x86_64.elf 2>&1 | tee %t0 | FileCheck %s
+// RUN: llvm-objdump -a -f -x -z %p/Inputs/private-headers-x86_64.elf 2>&1 | tee %t1
----------------
rupprecht wrote:
> Instead of tee, the standard way of doing this is to pass the file via FileCheck --input-file, e.g.
> RUN: llvm-objdump -afxz ... > %t0
> RUN: llvm-objdump -a -f -x -z ... > %t1
> RUN: cmp %t0 %t1
> RUN: FileCheck %s --input-file %t0
Good to know. Will fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57904/new/

https://reviews.llvm.org/D57904