[PATCH] D58166: [BPI] Look through bitcasts in calcZeroHeuristic

John Brawn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 15 03:39:17 PST 2019


john.brawn accepted this revision.
john.brawn added a comment.
This revision is now accepted and ready to land.

LGTM. Looking at it it does make me wonder if we should handle things that aren't ConstantInt, e.g.

  bitcast <2 x i16> <i16 0, i16 0> to i32

is still zero, though I'm guessing things like this actually probably never happen and this commit is fine as it is anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58166/new/

https://reviews.llvm.org/D58166





More information about the llvm-commits mailing list