[PATCH] D58096: [LowerSwitch][AMDGPU] Do not handle impossible values

[Roman Tereshin via Phabricator via llvm-commits]

rtereshin marked an inline comment as done.
rtereshin added inline comments.


================
Comment at: lib/Transforms/Utils/LowerSwitch.cpp:448-450
+  LLVM_DEBUG(dbgs() << "Clusterify finished. Total clusters: " << Cases.size()
+                    << ". Total non-default cases: " << NumSimpleCases << "\n");
+  LLVM_DEBUG(dbgs() << "Case clusters: " << Cases << "\n");
----------------
arsenm wrote:
> These can be merged into one LLVM_DEBUG (and single quotes around \n)
> These can be merged into one LLVM_DEBUG

Sure, will do.

> and single quotes around \n

Why?
```
grep -Eroh "<<\s*['\"]\\\?.['\"]" ./ --include='*.cpp' --include='*.h' --exclude-dir=build | grep -o "['\"]" | sort | uniq -c | sort -n
```
returns
```
6492 '
12003 "
```
(the example output of the first regex:
```
<< '"'
<< '['
<< '\n'
<< '\t'
<< '\n'
<< '\n'
<< "\n"
<< ":"
<< ":"
<< "\n"
<< "\n"
<< "\n"
<< "\n"
<< "\n"
<< "\n"
<< "\n"
<< " "
```
the current folder includes TOT llvm w/o clang or other projects)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58096/new/

https://reviews.llvm.org/D58096