[PATCH] D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used.

[Dan Liew via Phabricator via llvm-commits]

delcypher added inline comments.


================
Comment at: llvm/trunk/CMakeLists.txt:133
+  set(LLVM_ENABLE_PROJECTS_USED ON CACHE BOOL "" FORCE)
+  foreach(proj ${LLVM_ALL_PROJECTS})
+    string(TOUPPER "${proj}" upper_proj)
----------------
beanz wrote:
> FYI, by changing this loop from `LLVM_ENABLE_PROJECTS` to `LLVM_ALL_PROJECTS`, you're no longer covering potential external projects specified via `LLVM_EXTERNAL_PROJECTS`.
> 
> It is pretty straightforward to fix this by adding `LLVM_EXTERNAL_PROJECTS` here, which I will do in a patch shortly.
@beanz That's deliberate. If a project is not specified in `LLVM_ENABLE_PROJECTS` we need to make sure we set `LLVM_TOOL_${upper_proj}_BUILD` to `FALSE` for every project not specified in `LLVM_ENABLE_PROJECTS`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57535/new/

https://reviews.llvm.org/D57535