[llvm] r354070 - Replace gcroot verifier tests

[Matt Arsenault via llvm-commits]

Author: arsenm
Date: Thu Feb 14 14:41:01 2019
New Revision: 354070

URL: http://llvm.org/viewvc/llvm-project?rev=354070&view=rev
Log:
Replace gcroot verifier tests

These haven't been checking anything useful and have been testing the
wrong failure reason for many years. Replace them with something which
stresses what is actually implemented in the verifier now.

Added:
    llvm/trunk/test/Verifier/gcroot.ll
Removed:
    llvm/trunk/test/Verifier/gcroot-alloca.ll
    llvm/trunk/test/Verifier/gcroot-meta.ll
    llvm/trunk/test/Verifier/gcroot-ptrptr.ll

Removed: llvm/trunk/test/Verifier/gcroot-alloca.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/gcroot-alloca.ll?rev=354069&view=auto
==============================================================================
--- llvm/trunk/test/Verifier/gcroot-alloca.ll (original)
+++ llvm/trunk/test/Verifier/gcroot-alloca.ll (removed)
@@ -1,14 +0,0 @@
-; RUN: not llvm-as < %s > /dev/null 2>&1
-; PR1633
-
-%meta = type { i8* }
-%obj = type { %meta* }
-
-declare void @llvm.gcroot(%obj**, %meta*)
-
-define void @f() {
-entry:
-	call void @llvm.gcroot(%obj** null, %meta* null)
-	
-	ret void
-}

Removed: llvm/trunk/test/Verifier/gcroot-meta.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/gcroot-meta.ll?rev=354069&view=auto
==============================================================================
--- llvm/trunk/test/Verifier/gcroot-meta.ll (original)
+++ llvm/trunk/test/Verifier/gcroot-meta.ll (removed)
@@ -1,16 +0,0 @@
-; RUN: not llvm-as < %s > /dev/null 2>&1
-; PR1633
-
-%meta = type { i8* }
-%obj = type { %meta* }
-
-declare void @llvm.gcroot(%obj**, %meta*)
-
-define void @f() {
-entry:
-	%local.obj = alloca %obj*
-	%local.meta = alloca %meta
-	call void @llvm.gcroot(%obj** %local.obj, %meta* %local.meta)
-	
-	ret void
-}

Removed: llvm/trunk/test/Verifier/gcroot-ptrptr.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/gcroot-ptrptr.ll?rev=354069&view=auto
==============================================================================
--- llvm/trunk/test/Verifier/gcroot-ptrptr.ll (original)
+++ llvm/trunk/test/Verifier/gcroot-ptrptr.ll (removed)
@@ -1,14 +0,0 @@
-; RUN: not llvm-as < %s > /dev/null 2>&1
-; PR1633
-
-%meta = type { i8* }
-%obj = type { %meta* }
-
-declare void @llvm.gcroot(%obj*, %meta*)
-
-define void @f() {
-entry:
-	%local.obj = alloca %obj
-	call void @llvm.gcroot(%obj* %local.obj, %meta* null)
-	ret void
-}

Added: llvm/trunk/test/Verifier/gcroot.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/gcroot.ll?rev=354070&view=auto
==============================================================================
--- llvm/trunk/test/Verifier/gcroot.ll (added)
+++ llvm/trunk/test/Verifier/gcroot.ll Thu Feb 14 14:41:01 2019
@@ -0,0 +1,52 @@
+; RUN: not llvm-as -o /dev/null %s 2>&1 | FileCheck %s
+; PR1633
+
+declare void @llvm.gcroot(i8**, i8*)
+
+define void @caller_must_use_gc() {
+  ; CHECK: Enclosing function does not use GC.
+  ; CHECK-NEXT: call void @llvm.gcroot(i8** %alloca, i8* null)
+  %alloca = alloca i8*
+  call void @llvm.gcroot(i8** %alloca, i8* null)
+  ret void
+}
+
+define void @must_be_alloca() gc "test" {
+; CHECK: llvm.gcroot parameter #1 must be an alloca.
+; CHECK-NEXT: call void @llvm.gcroot(i8** null, i8* null)
+  call void @llvm.gcroot(i8** null, i8* null)
+  ret void
+}
+
+define void @non_ptr_alloca_null() gc "test" {
+  ; CHECK: llvm.gcroot parameter #1 must either be a pointer alloca, or argument #2 must be a non-null constant.
+  ; CHECK-NEXT: call void @llvm.gcroot(i8** %cast.alloca, i8* null)
+  %alloca = alloca i32
+  %cast.alloca = bitcast i32* %alloca to i8**
+  call void @llvm.gcroot(i8** %cast.alloca, i8* null)
+  ret void
+}
+
+define void @non_constant_arg1(i8* %arg) gc "test" {
+  ; CHECK: llvm.gcroot parameter #2 must be a constant.
+  ; CHECK-NEXT: call void @llvm.gcroot(i8** %alloca, i8* %arg)
+  %alloca = alloca i8*
+  call void @llvm.gcroot(i8** %alloca, i8* %arg)
+  ret void
+}
+
+define void @non_ptr_alloca_non_null() gc "test" {
+; CHECK-NOT: llvm.gcroot parameter
+  %alloca = alloca i32
+  %cast.alloca = bitcast i32* %alloca to i8**
+  call void @llvm.gcroot(i8** %cast.alloca, i8* inttoptr (i64 123 to i8*))
+  ret void
+}
+
+define void @casted_alloca() gc "test" {
+; CHECK-NOT: llvm.gcroot parameter
+  %alloca = alloca i32*
+  %ptr.cast.alloca = bitcast i32** %alloca to i8**
+  call void @llvm.gcroot(i8** %ptr.cast.alloca, i8* null)
+  ret void
+}