[PATCH] D57904: [llvm-objdump] Allow short options to be grouped

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 14 14:24:55 PST 2019


rupprecht added a comment.

I think you can still add tests for the other options, e.g. `test/tools/llvm-objdump/X86/macho-disassembly-g-dsym.test` tests `-d -g`, so you could add another run statement to that test with `-dg` and use `cmp` to verify it produces the same thing



================
Comment at: llvm/test/tools/llvm-objdump/option-grouping.test:1
+// RUN: llvm-objdump -afxz %p/Inputs/private-headers-x86_64.elf 2>&1 | FileCheck %s
+// CHECK-NOT: Unknown command line argument
----------------
This should also verify it produces the same output as `-a -f -x -z`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57904/new/

https://reviews.llvm.org/D57904





More information about the llvm-commits mailing list