[PATCH] D58244: Canonicalize all "idempotent" atomicrmw ops

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 14 11:35:45 PST 2019


reames added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineAtomicRMW.cpp:65
+    return &RMWI;
+  }
 
----------------
jfb wrote:
> I don't think you want to canonicalize volatile accesses this way.
Why?  It's not changing the memory op implied.  I can easy restrict, but why?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58244/new/

https://reviews.llvm.org/D58244





More information about the llvm-commits mailing list