[PATCH] D58244: Canonicalize all "idempotent" atomicrmw ops

[JF Bastien via Phabricator via llvm-commits]

jfb requested changes to this revision.
jfb added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/Transforms/InstCombine/InstCombineAtomicRMW.cpp:65
+    return &RMWI;
+  }
 
----------------
I don't think you want to canonicalize volatile accesses this way.


================
Comment at: test/Transforms/InstCombine/atomicrmw.ll:92
 ; By eliminating the store part of the atomicrmw, we would get rid of the
-; release semantic, which is incorrect.
-; CHECK-LABEL: atomic_or_zero_seq_cst
+; release semantic, which is incorrect.  We can canonicalize the oepration.
+; CHECK-LABEL: atomic_seq_cst
----------------
typo


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58244/new/

https://reviews.llvm.org/D58244