[PATCH] D57938: [WebAssembly] Update MC for bulk memory

Thu Feb 14 10:51:39 PST 2019

tlively marked 2 inline comments as done.
tlively added inline comments.

================
Comment at: llvm/test/MC/WebAssembly/external-data.ll:1
-; RUN: llc -filetype=obj %s -o - | obj2yaml | FileCheck %s
+; RUN: llc -filetype=obj -thread-model=single %s -o - | obj2yaml | FileCheck %s

----------------
sbc100 wrote:
> tlively wrote:
> > sbc100 wrote:
> > > Why do this, given that single is still the default?  
> > Single is the default for clang, but not for llc.
> Hmm, that doesn't seem great.  We don't want llc, but default, generating code that requires the threads proposal.  Maybe we should fix that? 
>  (unless its particularly awkward).
I'm not sure that needs to be changed, but if it does we should do that as a separate CL.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57938/new/

https://reviews.llvm.org/D57938