[PATCH] D58102: Support X86 Control-flow Enforcement Technology (CET) in LLD

Thu Feb 14 10:29:15 PST 2019

ruiu added a comment.

Can I ask a few random questions to understand the design of the patch?

1. In the patch description, it says that lld checks if all input object files contains a certain marker .note section. What is supposed to happen if some object files miss the .note section? Do we silently disable the feature in that case?

2. Why did you choose to create a separate section .splt instead of just writing different contents to .plt?

3. Do you really want to support i386 (as opposed to x86-64)? I'm genuinely curious who would want to use the feature in the 32-bit mode.

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58102/new/

https://reviews.llvm.org/D58102