[PATCH] D53927: [AArch64] Enable libm vectorized functions via SLEEF

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 14 02:52:53 PST 2019


rengolin added inline comments.


================
Comment at: include/llvm/Analysis/TargetLibraryInfo.def:315
+/// double __gamma_r_finite(double x, int* s);
+TLI_DEFINE_ENUM_INTERNAL(tgamma_finite)
+TLI_DEFINE_STRING_INTERNAL("__gamma_r_finite")
----------------
bryanpkc wrote:
> rengolin wrote:
> > Probably a silly question but, why "tgamma" when the function name is "gamma"?
> This didn't work in my test build. The function names must be in alphabetical order, so `__gamma_r_finite` etc. cannot come after `__isoc99_scanf`.
Better move to alphabetical order, then. Would that remove the need to call it "tgamma"?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53927/new/

https://reviews.llvm.org/D53927





More information about the llvm-commits mailing list