[compiler-rt] r354014 - Revert "Temporarily disable calls to getgrnam/getgrnam_r in test due to it hitting unrelated issues in EGLIBC 2.19."

Douglas Yung via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 14 02:39:11 PST 2019


Author: dyung
Date: Thu Feb 14 02:39:11 2019
New Revision: 354014

URL: http://llvm.org/viewvc/llvm-project?rev=354014&view=rev
Log:
Revert "Temporarily disable calls to getgrnam/getgrnam_r in test due to it hitting unrelated issues in EGLIBC 2.19."

This reverts commit r353594.

We have updated our internal build bot to a newer version of LIBC which does not have this problem.

Modified:
    compiler-rt/trunk/test/sanitizer_common/TestCases/Posix/getpw_getgr.cc

Modified: compiler-rt/trunk/test/sanitizer_common/TestCases/Posix/getpw_getgr.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/Posix/getpw_getgr.cc?rev=354014&r1=354013&r2=354014&view=diff
==============================================================================
--- compiler-rt/trunk/test/sanitizer_common/TestCases/Posix/getpw_getgr.cc (original)
+++ compiler-rt/trunk/test/sanitizer_common/TestCases/Posix/getpw_getgr.cc Thu Feb 14 02:39:11 2019
@@ -72,8 +72,7 @@ int main(int argc, const char *argv[]) {
   test<passwd>(&getpwuid, 0);
   test<passwd>(&getpwnam, "root");
   test<group>(&getgrgid, 0);
-  // Disable this test for now since it seems to hit a bug in EGLIBC 2.19
-  //test<group>(&getgrnam, any_group.c_str());
+  test<group>(&getgrnam, any_group.c_str());
 
 #if !defined(__ANDROID__)
   setpwent();
@@ -92,8 +91,7 @@ int main(int argc, const char *argv[]) {
   test_r<passwd>(&getpwnam_r, "root");
 
   test_r<group>(&getgrgid_r, 0);
-  // Disable this test for now since it seems to hit a bug in EGLIBC 2.19
-  //test_r<group>(&getgrnam_r, any_group.c_str());
+  test_r<group>(&getgrnam_r, any_group.c_str());
 
 #if defined(__linux__)
   auto pwd_file = [] {




More information about the llvm-commits mailing list