[PATCH] D58221: [msan] Don't delete MSanAtExitRecord

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 13 18:03:34 PST 2019


eugenis added inline comments.


================
Comment at: compiler-rt/test/msan/cxa_atexit_race.cc:24
+    pthread_create(&pt, 0, &thread, 0);
+  sleep(1);
+  return 1;
----------------
I'm not sure about this .The other thread can register _a lot_ of handlers in one second.


================
Comment at: compiler-rt/test/msan/cxa_atexit_race.cc:25
+  sleep(1);
+  return 1;
+}
----------------
return 0 and remove "not" before "%run" ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58221/new/

https://reviews.llvm.org/D58221





More information about the llvm-commits mailing list