[PATCH] D57938: [WebAssembly] Update MC for bulk memory

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 13 14:19:04 PST 2019


sbc100 added inline comments.


================
Comment at: llvm/test/MC/WebAssembly/external-data.ll:1
-; RUN: llc -filetype=obj %s -o - | obj2yaml | FileCheck %s
+; RUN: llc -filetype=obj -thread-model=single %s -o - | obj2yaml | FileCheck %s
 
----------------
tlively wrote:
> sbc100 wrote:
> > Why do this, given that single is still the default?  
> Single is the default for clang, but not for llc.
Hmm, that doesn't seem great.  We don't want llc, but default, generating code that requires the threads proposal.  Maybe we should fix that? 
 (unless its particularly awkward).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57938/new/

https://reviews.llvm.org/D57938





More information about the llvm-commits mailing list