[PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

Tue Feb 12 23:27:24 PST 2019

labath added a subscriber: sas.
labath added a comment.

In D56237#1395791 <https://reviews.llvm.org/D56237#1395791>, @Hui wrote:

> In D56237#1394320 <https://reviews.llvm.org/D56237#1394320>, @labath wrote:
>
> > I like the direction this is going. I have one small comment about the code organization inline, but the bigger question I have in mind is: After these changes, is there any use for `Host::GetProcessBaseAddress` left? If so, what is it? I'd like to understand it and remove it.
>
>
> From my understanding, lldb-server.exe is to debug a process instantiated by NativeProcessProtocol which might or might not relate to ProcessWindows plugin.
>
> To remove the host codes mentioned above, it requires the implementation of NativeProcessProtocol also notify the DYLD the load address of the main executable otherwise
>  DYLD has to do the job with the OS help. For now I think just remove them.

Yes, the NativeProcessWindows will need to notify the DYLD about the load address somehow. If DYLD went and did that on it's own, it would kill the "remote" aspect of lldb-server, as the DYLD plugin lives in the client. I think @sas is already passing that information somehow with ds2, so it might be good to sync up with him, so we don't reinvent something new. (My guess would be that they just have ds2 implement the packet underlying the `GetFileLoadAddress()` call.)

It short, let's remove the host code for now, and we can discuss that again after we get around to implementing NativeProcessWindows or whatever.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56237/new/

https://reviews.llvm.org/D56237