[PATCH] D57909: [WebAssembly] Don't generate invalid modules when function signatures mismatch

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 12 19:49:56 PST 2019


ruiu added inline comments.


================
Comment at: lld/wasm/Options.td:94
 
+def signature_check_strict: F<"signature-check-strict">,
+  HelpText<"Error on function signature mismatch">;
----------------
A little bikeshedish, but `--signature-check=strict` or `--strict-signature-check` feel natural to me, but `--signature-check-strict` seems a bit odd as a command line option name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57909/new/

https://reviews.llvm.org/D57909





More information about the llvm-commits mailing list