[PATCH] D57718: [PPC] Adjust the computed branch offset for the possible shorter distance

Guozhi Wei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 12 14:44:49 PST 2019


Carrot added a comment.

In D57718#1394924 <https://reviews.llvm.org/D57718#1394924>, @jsji wrote:

> I think we should be able to come up with a smaller test case that demonstrate the problem here? 
>  No necessary causing run time problem due to wrong branch, 
>  but causing `smaller` calculated branch offset, and we can check that by adding a few `dbgs()` to check calculated branch offset in code?


Because of the code at line 137

  if (FuncSize < (1 << 15)) {
    BlockSizes.clear();
    return false;
  }

Even if you just want to trigger the patched code, the smaller test case still need to be at least 16KB.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57718/new/

https://reviews.llvm.org/D57718





More information about the llvm-commits mailing list