[PATCH] D57468: Strengthen handling of GEPs and generic calls for all undef lanes

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 12 11:27:50 PST 2019


spatel added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:1884
+
+    if (UndefElts.isAllOnesValue())
+      return replaceInstUsesWith(*II, UndefValue::get(II->getType()));
----------------
I'm not sure how to expose this in a regression test, but would it make sense to add this check to the bottom of SimplifyDemandedVectorElts() itself, so callers don't have to deal with this possibility themselves?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57468/new/

https://reviews.llvm.org/D57468





More information about the llvm-commits mailing list