[PATCH] D58138: [GlobalISel][NFC] Gardening: Factor out more intrinsics into simple intrinsics

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 12 10:29:18 PST 2019


paquette created this revision.
paquette added reviewers: aemerson, dsanders, arsenm.
Herald added subscribers: Petar.Avramovic, volkan, kristof.beyls, rovka, wdng.

Found another place where we can just factor out a bunch of intrinsics and make it a bit easier to add more of these. The only difference between a "simple intrinsic" and, say, the overflow intrinsics is that simple intrinsics only have a single result.

This teaches translateSimpleIntrinsic to handle an arbitrary number of destination registers. Then we can factor out all of the overflow intrinsics, and delete `translateOverflowIntrinsic` entirely. Also makes the overflow intrinsics respect IR flags, which weren't being copied over in `translateOverflowIntrinsic`.

By doing this, we can add IRTranslator support for any intrinsic that can be "straight-line" translated by adding it to `getSimpleIntrinsicOpcode`.


https://reviews.llvm.org/D58138

Files:
  include/llvm/CodeGen/GlobalISel/IRTranslator.h
  lib/CodeGen/GlobalISel/IRTranslator.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58138.186511.patch
Type: text/x-patch
Size: 3844 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190212/17164d97/attachment.bin>


More information about the llvm-commits mailing list