[PATCH] D58066: [MCA][Scheduler] Use latency information to further classify busy instructions.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.

LGTM with a couple of minors



================
Comment at: include/llvm/MCA/Instruction.h:458
+  // Force a transition from the IS_DISPATCHED state to the IS_READY or
+  // IS_WAITING state. State transitions normally occur either at the beginning
+  // of a new cycle (see method cycleEvent()), or as a result of another issue
----------------
IS_PENDING


================
Comment at: lib/MCA/Instruction.cpp:163
+
+  if (!all_of(getDefs(), IsDefReady))
+    return false;
----------------
As discussed offline please consistently embed/separate all the lambdas and the all_of calls.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58066/new/

https://reviews.llvm.org/D58066