[PATCH] D58034: [IR/DIVar] Add flag for params that have unchanged values

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 12 09:32:28 PST 2019


aprantl added a comment.

Yeah, that makes sense. It would be very hard to analyze this without either false positives or a ton of false negatives. I also see that while every constant is trivially not changed, the opposite is not true.

Could you please add a round-trip test (like or perhaps even in test/Assembler/debug-info.ll )?



================
Comment at: include/llvm/IR/DebugInfoFlags.def:62
 HANDLE_DI_FLAG((1 << 29), AllCallsDescribed)
+HANDLE_DI_FLAG((1 << 30), VariableNotChanged)
 
----------------
The attribute it named `VariableNotChanged`, but IIUC, this can only be applied to function arguments? Should it be called `ArgumentNotModified` instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58034/new/

https://reviews.llvm.org/D58034





More information about the llvm-commits mailing list