[PATCH] D58132: lld/elf: When demangling symbols, surround demangled symbol with quotes and include mangled symbol as well

Tue Feb 12 08:48:35 PST 2019

thakis created this revision.
thakis added a reviewer: ruiu.
Herald added subscribers: erik.pilkington, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

The demangled string can contain spaces, so the quotes make things a bit easier to read. Two different mangled symbols might demangle to the same string (e.g. _ZN3fooC1Ev and _ZN3fooC2Ev), so including the mangled name makes it possible to differentiate them if needed.

Makes lld/elf consistent with lld/coff's output.

https://reviews.llvm.org/D58132

Files:
  lld/ELF/Symbols.cpp
  lld/test/ELF/conflict-variable-linkage-name.s
  lld/test/ELF/conflict.s
  lld/test/ELF/debug-line-str.s
  lld/test/ELF/linkerscript/map-file2.test
  lld/test/ELF/map-file.s
  lld/test/ELF/undef.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58132.186487.patch
Type: text/x-patch
Size: 4981 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190212/a87ddd4d/attachment.bin>