[PATCH] D57968: [LICM] Cap the clobbering calls in LICM.

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv accepted this revision.
george.burgess.iv marked an inline comment as done.
george.burgess.iv added a comment.

Deferring to Chandler's LGTM for the approach + first patch; changes since then LGTM.

Thanks again!



================
Comment at: include/llvm/Transforms/Utils/LoopUtils.h:115
                 AliasSetTracker *, MemorySSAUpdater *, ICFLoopSafetyInfo *,
-                bool, OptimizationRemarkEmitter *);
+                bool, int &, OptimizationRemarkEmitter *);
 
----------------
asbirlea wrote:
> george.burgess.iv wrote:
> > Nit: I'm OK with this as is, but if we grow another MSSA-related optimization limit/counter, please wrap the MSSA-related bits into some sort of options struct (a bit in spirit like `llvm::ObjectSizeOpts`, but we'd also be tracking the mutable `EnableLicmCapCounter`/etc in it)
> Noted, and I agree! I considered adding this in this patch, actually.
> Additional refactoring may help somewhat, since the only user of sinkRegion and hoistRegion is LICM. We'd still needs these bits wrapped up for canSinkAndHoist which is used in LoopSink.
> Leaving it as a separate cleanup for now.
SGTM


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57968/new/

https://reviews.llvm.org/D57968