[PATCH] D57533: lit: support long paths on Windows

Mon Feb 11 13:22:14 PST 2019

efriedma added inline comments.

================
Comment at: utils/lit/lit/TestRunner.py:614
+                    # to use the NT style path to get access to long file paths
+                    # which cannot be removed otherwise.
+                    from ctypes.wintypes import BOOL, HWND, LPCWSTR, POINTER, UINT, WORD
----------------
compnerd wrote:
> efriedma wrote:
> > Please add a comment noting which version of python, exactly, are known to have a broken shutil.rmtree, so we can potentially remove this hack in the future.
> @efriedma my understanding is that they all do.  I know that they did switch to the Wide version of the interfaces in 3.5/3.7, so we might be able to pass an explicit `unicode` string, but, really, this is unlikely to be something that we can easily remove.
If all current versions are broken, fine; please still note the versions that were tested.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57533/new/

https://reviews.llvm.org/D57533