[llvm] r353741 - [globalisel] Restore comment explaining the nits of GISelChangeObserver::createdInstr()

[Daniel Sanders via llvm-commits]

Author: dsanders
Date: Mon Feb 11 12:05:49 2019
New Revision: 353741

URL: http://llvm.org/viewvc/llvm-project?rev=353741&view=rev
Log:
[globalisel] Restore comment explaining the nits of GISelChangeObserver::createdInstr()


Modified:
    llvm/trunk/include/llvm/CodeGen/GlobalISel/GISelChangeObserver.h

Modified: llvm/trunk/include/llvm/CodeGen/GlobalISel/GISelChangeObserver.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/GlobalISel/GISelChangeObserver.h?rev=353741&r1=353740&r2=353741&view=diff
==============================================================================
--- llvm/trunk/include/llvm/CodeGen/GlobalISel/GISelChangeObserver.h (original)
+++ llvm/trunk/include/llvm/CodeGen/GlobalISel/GISelChangeObserver.h Mon Feb 11 12:05:49 2019
@@ -33,10 +33,17 @@ public:
 
   /// An instruction is about to be erased.
   virtual void erasingInstr(MachineInstr &MI) = 0;
-  /// An instruction was created and inserted into the function.
+
+  /// An instruction has been created and inserted into the function.
+  /// Note that the instruction might not be a fully fledged instruction at this
+  /// point and won't be if the MachineFunction::Delegate is calling it. This is
+  /// because the delegate only sees the construction of the MachineInstr before
+  /// operands have been added.
   virtual void createdInstr(MachineInstr &MI) = 0;
+
   /// This instruction is about to be mutated in some way.
   virtual void changingInstr(MachineInstr &MI) = 0;
+
   /// This instruction was mutated in some way.
   virtual void changedInstr(MachineInstr &MI) = 0;